rok commented on code in PR #635:
URL: https://github.com/apache/parquet-format/pull/635#discussion_r4467778673
##########
LogicalTypes.md:
##########
@@ -769,14 +771,15 @@ set:
| - | - | set | set | invalid
|
| - | - | - | - | nothing - invalid
|
-† The locator fields may all be unset. Otherwise, fields set alongside
`inline` must
-form a locator valid on its own, so `offset` requires `uri` and `size`.
+† The locator fields may all be unset, or `size` may be set alone, in which
case it
+must equal the length of `inline`. Otherwise, fields set alongside `inline`
must form a
+locator valid on its own, so `offset` requires `uri` and `size`.
`size` must be set whenever `offset` is set, so any offset-based read always
carries an
-explicit `size`. `size` may be omitted only for a whole-file external
reference, where
-the range runs to the end of the referenced file. `offset` and `size` apply
only to data
-referenced by `uri`; there is no form that addresses a byte range in the
current file
-directly.
+explicit `size`. `size` may be omitted when `inline` is set, or for a
whole-file external
+reference, where the range runs to the end of the referenced file. `offset`
applies only
+to data referenced by `uri`; there is no form that addresses a byte range in
the current
+file directly.
Review Comment:
Makse sense!
##########
LogicalTypes.md:
##########
@@ -769,14 +771,15 @@ set:
| - | - | set | set | invalid
|
| - | - | - | - | nothing - invalid
|
-† The locator fields may all be unset. Otherwise, fields set alongside
`inline` must
-form a locator valid on its own, so `offset` requires `uri` and `size`.
+† The locator fields may all be unset, or `size` may be set alone, in which
case it
+must equal the length of `inline`. Otherwise, fields set alongside `inline`
must form a
+locator valid on its own, so `offset` requires `uri` and `size`.
`size` must be set whenever `offset` is set, so any offset-based read always
carries an
-explicit `size`. `size` may be omitted only for a whole-file external
reference, where
-the range runs to the end of the referenced file. `offset` and `size` apply
only to data
-referenced by `uri`; there is no form that addresses a byte range in the
current file
-directly.
+explicit `size`. `size` may be omitted when `inline` is set, or for a
whole-file external
+reference, where the range runs to the end of the referenced file. `offset`
applies only
+to data referenced by `uri`; there is no form that addresses a byte range in
the current
+file directly.
Review Comment:
Makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
