adriangb commented on code in PR #628:
URL: https://github.com/apache/parquet-format/pull/628#discussion_r4467212602
##########
src/main/thrift/parquet.thrift:
##########
@@ -289,7 +289,10 @@ struct Statistics {
* If null_count is not present, readers MUST NOT assume null_count == 0.
*/
3: optional i64 null_count;
- /** count of distinct values occurring */
+ /**
+ * Estimated count of distinct values occurring.
+ * The estimate may be off in either direction by an underfined amount.
Review Comment:
I adopted the suggested wording in 3c7d0b7 since that seems to be the
majority opinion.
I am however worried that moving forward with that is also a breaking
change. Right now exactness is `undefined` or `unknown`. If we go with the
wording in 3c7d0b7 any writer that used to write an estimate is now in
violation of the spec.
It might be better to drop any attempt to define this field and instead make
a new field and deprecate this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]