RussellSpitzer opened a new pull request, #3933:
URL: https://github.com/apache/parquet-java/pull/3933

   ### Rationale for this change
   
   prepare-rc.sh only ran versions:set, so <scm><tag> in the root POM kept 
whatever the release branch carried. The 1.18.2 RCs shipped 
apache-parquet-1.18.0-rc2 and the 1.19.0 RCs shipped HEAD.
   
   ### What changes are included in this PR?
   
   - prepare-rc.sh writes the RC tag into <scm><tag> in the release commit, 
including on rc1+ when the version is already set, and refuses to tag and 
deploy if the committed tag doesn't match.
   - publish-release.sh checks out the release branch before comparing it with 
the RC tag (the workflow is dispatched from master), and resets <scm><tag> to 
HEAD in the next development iteration commit.
   
   ### Are these changes tested?
   
   Locally checked that we are correctly checking and creating poms correctly
   
   ### Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to