RussellSpitzer commented on code in PR #3935: URL: https://github.com/apache/parquet-java/pull/3935#discussion_r4553510440
########## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/FullBodyEncryptedDataPageV2.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.parquet.hadoop; + +import java.io.IOException; +import org.apache.parquet.SemanticVersion; +import org.apache.parquet.Strings; +import org.apache.parquet.VersionParser; +import org.apache.parquet.VersionParser.ParsedVersion; +import org.apache.parquet.VersionParser.VersionParseException; +import org.apache.parquet.bytes.ByteBufferInputStream; +import org.apache.parquet.bytes.BytesInput; +import org.apache.parquet.bytes.BytesUtils; +import org.apache.parquet.column.Encoding; +import org.apache.parquet.column.page.DataPageV2; +import org.apache.parquet.column.statistics.Statistics; + +/** + * An encrypted DataPageV2 whose body, levels included, is one encrypted module. The body is held as + * {@link #getData()} and the levels are empty until {@code ColumnChunkPageReader} decrypts the page + * and splits the body using the level lengths. + */ +final class FullBodyEncryptedDataPageV2 extends DataPageV2 { + + /** How the body of an encrypted DataPageV2 page that has levels is laid out. */ + enum Layout { + /** {@code [module of levels and values]} */ + SINGLE_MODULE, + /** {@code [plaintext levels][module of values]} */ + PLAINTEXT_LEVELS + } + + private static final SemanticVersion SINGLE_MODULE_SINCE = new SemanticVersion(1, 19, 0); + + private final int repetitionLevelsByteLength; + private final int definitionLevelsByteLength; + + /** + * @param encryptedBody {@code length (4 bytes, LE) | nonce | ciphertext [| tag]} + * @param uncompressedSize uncompressed page size, levels included + */ + FullBodyEncryptedDataPageV2( + int rowCount, + int nullCount, + int valueCount, + Encoding dataEncoding, + BytesInput encryptedBody, + int repetitionLevelsByteLength, + int definitionLevelsByteLength, + int uncompressedSize, + Statistics<?> statistics, + boolean isCompressed) { + super( + rowCount, + nullCount, + valueCount, + BytesInput.empty(), + BytesInput.empty(), + dataEncoding, + encryptedBody, + uncompressedSize, + statistics, + isCompressed); + this.repetitionLevelsByteLength = repetitionLevelsByteLength; + this.definitionLevelsByteLength = definitionLevelsByteLength; + } + + int getRepetitionLevelsByteLength() { + return repetitionLevelsByteLength; + } + + int getDefinitionLevelsByteLength() { + return definitionLevelsByteLength; + } + + /** + * Detects the layout of the body of a page that has levels. A module starts with the length of the + * rest of the module as a 4 byte LE int, so: + * + * <ul> + * <li>{@link Layout#SINGLE_MODULE}: the int at offset 0 is {@code size - 4} + * <li>{@link Layout#PLAINTEXT_LEVELS}: the int at offset {@code levelsByteLength} is {@code size - + * levelsByteLength - 4} + * </ul> + * + * If both hold, the layout is the one written by {@code createdBy}. If neither holds, the page is Review Comment: The other option here is to have an "Ambiguous state" and try at to decrypt the whole body later and see whether or not the GCM tag matches, if it doesn't you can fall back to the legacy parsing. The problem is that we also allow CTR which has no tag and just puts you in a decode garbage situation. So Instead I chose to just check the created_by in the ambiguous state. I think theoretically we could always just use created_by but this is a little safer for folks who forked and changed the Parquet version string to something unrecognizable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
