Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/323#discussion_r208713485
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -395,7 +395,10 @@ public KeyValueScanner preStoreScannerOpen(final
ObserverContext<RegionCoprocess
.getReader().getHFileReader().hasMVCCInfo(),
readPt));
}
}
- keyValueScanners.addAll(((HStore)
store).memstore.getScanners(readPt));
+ List<KeyValueScanner> memstoreScanners = ((HStore)
store).memstore.getScanners(readPt);
--- End diff --
In general, we don't ever want to be casting the interface (`Store`) to the
implementation (`HStore`). Is phoenix fundamentally doing something here that
requires it to be tied to some specific HStore functionality?
---
