Hadoop QA commented on PHOENIX-4750:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against master branch at commit d14bbdb6a27f08c87bb70dc128c1a696404766f2.
  ATTACHMENT ID: 12935141

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    public static final String QUERY_SERVER_CUSTOMIZERS_ENABLED = 
+            // Launch PQS, doing in the Kerberos login instead of letting PQS 
do it itself (which would
+        InstanceResolver.getSingleton(ServerCustomizersFactory.class, new 
ServerCustomizersFactory() {
+                return Collections.<ServerCustomizer<Server>>singletonList(new 
+                "create table "+ServerCustomizersIT.class.getSimpleName()+" 
(pk integer not null primary key)"));
+            login.putUser(USER_AUTHORIZED, Credential.getCredential(USER_PW), 
new String[] {"users"});
+  public void enableServerCustomizersIfNecessary(HttpServer.Builder<Server> 
builder, Configuration conf) {
+        InstanceResolver.getSingleton(ServerCustomizersFactory.class, new 
ServerCustomizersFactory() {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results: 
Console output: 

This message is automatically generated.

> Resolve server customizers and provide them to Avatica
> ------------------------------------------------------
>                 Key: PHOENIX-4750
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4750
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Alex Araujo
>            Assignee: Alex Araujo
>            Priority: Major
>              Labels: queryserver
>             Fix For: 4.15.0, 5.1.0
>         Attachments: PHOENIX-4750.patch, PHOENIX-4750.v2.patch, 
> PHOENIX-4750.v3.patch, PHOENIX-4750.v4.patch
> CALCITE-2284 allows finer grained customization of the underlying Avatica 
> HttpServer.
> Resolve server customizers on the PQS classpath and provide them to the 
> HttpServer builder.

This message was sent by Atlassian JIRA

Reply via email to