[ 
https://issues.apache.org/jira/browse/PHOENIX-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576983#comment-16576983
 ] 

Hadoop QA commented on PHOENIX-4843:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12935200/PHOENIX-4843-v2.patch
  against master branch at commit d14bbdb6a27f08c87bb70dc128c1a696404766f2.
  ATTACHMENT ID: 12935200

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            stmt.execute("CREATE VIEW IF NOT EXISTS " + tenantView + " AS 
SELECT * FROM " + fullViewName );
+            viewConn.createStatement().execute("UPSERT INTO " + tenantView + 
"(CREATED_BY, CREATED_DATE, SYSTEM_MODSTAMP, MODEL, MILEAGE, MILES_DRIVEN, 
MAKE) VALUES ('005xx000001Sv6o', 1532458254819, 1532458254819, 'a5', 23, 10000, 
'AUDI')");
+            viewConn.createStatement().execute("UPSERT INTO " + tenantView + 
"(CREATED_BY, CREATED_DATE, SYSTEM_MODSTAMP, MODEL, MILEAGE, MILES_DRIVEN, 
MAKE) VALUES ('005xx000001Sv6o', 1532458254819, 1532458254819, 'a4', 27, 30000, 
'AUDI')");
+            viewConn.createStatement().execute("UPSERT INTO " + tenantView + 
"(CREATED_BY, CREATED_DATE, SYSTEM_MODSTAMP, MODEL, MILEAGE, MILES_DRIVEN, 
MAKE) VALUES ('005xx000001Sv6o', 1532458254819, 1532458254819, '328i', 32, 
40000, 'BMW')");
+            ResultSet rs = stmt.executeQuery("SELECT Make, Model FROM " + 
tenantView + " WHERE MILEAGE IN (32, 27)");
+                type.coerceBytes(valueCopy, type, firstChild.getSortOrder(), 
SortOrder.getDefault());

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1972//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1972//console

This message is automatically generated.

> InListExpression toString() converts the values in the list to ASC sort order 
> always
> ------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4843
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4843
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4843-v2.patch, PHOENIX-4843-v3.patch, 
> PHOENIX-4843-v4.patch, PHOENIX-4843.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to