[
https://issues.apache.org/jira/browse/PHOENIX-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584334#comment-16584334
]
ASF GitHub Bot commented on PHOENIX-4853:
-----------------------------------------
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/330
PHOENIX-4853 Add sql statement to PhoenixMetricsLog interface for que…
…ry level metrics logging
@ankitsinghal @aaraujo @twdsilva Please review. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karanmehta93/phoenix 4.x-HBase-1.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #330
----
commit 9946f4f91cc9aa37b9f8da5ac7a35a7be3c98423
Author: Karan Mehta <karanmehta93@...>
Date: 2018-08-17T20:02:08Z
PHOENIX-4853 Add sql statement to PhoenixMetricsLog interface for query
level metrics logging
----
> Add sql statement to PhoenixMetricsLog interface for query level metrics
> logging
> --------------------------------------------------------------------------------
>
> Key: PHOENIX-4853
> URL: https://issues.apache.org/jira/browse/PHOENIX-4853
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
>
> We get query level metrics when we try to close the
> {{LoggingPhoenixResultSet}} object. It is better to add the SQL statement to
> the PhoenixMetricsLog interface so that we can attach the metrics to the
> exact SQL statement. This helps in debugging whenever we determine that
> particular query is taking a long time to run.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
