Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r214198941
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -154,6 +154,35 @@ private void verifyQueryLevelMetricsLogging(String
query) throws SQLException {
assertTrue(logRequestReadMetricsFuncCallCount == 1);
}
+ @Test
+ public void testPhoenixMetricsLoggedOnAutoCommit() throws Exception {
+ // Autocommit is turned on explicitly
+ loggedConn.setAutoCommit(true);
+ //with executeUpdate() method
+ // run SELECT to verify read metrics are logged
+ String query = "SELECT * FROM " + tableName1;
+ verifyQueryLevelMetricsLogging(query);
--- End diff --
nit: Not related to this Jira, but its better to rename this method to
`upsertRowsAndVerifyQueryLevelMetricsLogging`
---
