[
https://issues.apache.org/jira/browse/PHOENIX-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614192#comment-16614192
]
Hadoop QA commented on PHOENIX-4594:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12939607/PHOENIX-4594-0913.patch
against master branch at commit 2437049b408343255b4d00a2c50b97825df8cb0b.
ATTACHMENT ID: 12939607
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
PhoenixConfigurationUtil.getGuidePostsMovingWindowSize(conn.unwrap(PhoenixConnection.class));
+
PhoenixConfigurationUtil.setGuidePostsMovingWindowSize(conn.unwrap(PhoenixConnection.class),
+ // Query with multiple scan ranges, and each range's start key
and end key are both between data
+ sql = "SELECT a FROM " + tableName + " WHERE K <= 103 AND K >=
101 OR K <= 108 AND K >= 106";
+ // TODO: the original code before this change will hit the
following assertion. Need to investigate it.
+ // Query with multiple scan ranges which start with the min
key and end with the max key
+ sql = "SELECT a FROM " + tableName + " WHERE K <= 102 AND K >=
100 OR K <= 109 AND K >= 107";
+ this.gpsMovingWindowSize =
PhoenixConfigurationUtil.getGuidePostsMovingWindowSize(context.getConnection());
+ // case we generate an empty guide post with the byte estimate being
set as guide post width.
+ // Continuously decode and load guide posts in batches
and perform binary search in each batch,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2035//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2035//console
This message is automatically generated.
> Perform binary search on guideposts during query compilation
> ------------------------------------------------------------
>
> Key: PHOENIX-4594
> URL: https://issues.apache.org/jira/browse/PHOENIX-4594
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Assignee: Bin Shi
> Priority: Major
> Attachments: PHOENIX-4594-0913.patch
>
>
> If there are many guideposts, performance will suffer during query
> compilation because we do a linear search of the guideposts to find the
> intersection with the scan ranges. Instead, in
> BaseResultIterators.getParallelScans() we should populate an array of
> guideposts and perform a binary search.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
