[
https://issues.apache.org/jira/browse/PHOENIX-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618406#comment-16618406
]
Hadoop QA commented on PHOENIX-4907:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12940096/PHOENIX-4907.patch
against master branch at commit ba1fd712ae8cdc0fc20805a7b03b7df7b0258542.
ATTACHMENT ID: 12940096
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2039//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2039//console
This message is automatically generated.
> IndexScrutinyTool should use empty catalog instead of null
> ----------------------------------------------------------
>
> Key: PHOENIX-4907
> URL: https://issues.apache.org/jira/browse/PHOENIX-4907
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-4907.patch
>
>
> Before executing, the index scrutiny tool does a sanity check to make sure
> that the given data table and index are valid and related to each other. This
> check uses the JDBC metadata API, and passes in null for the catalog name.
> Unfortunately, a null entry for catalog causes Phoenix to omit tenant_id from
> the query against System.Catalog, causing a table scan, which can be lengthy
> or time out if the server has too many views.
> It should pass in the empty string for catalog, which will make Phoenix
> filter on "WHERE tenant_id is NULL", which will avoid the table scan.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
