[
https://issues.apache.org/jira/browse/PHOENIX-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619767#comment-16619767
]
ASF GitHub Bot commented on PHOENIX-4008:
-----------------------------------------
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/351#discussion_r218604650
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/schema/stats/StatsCollectorIT.java
---
@@ -38,6 +38,7 @@
import java.util.Properties;
import java.util.Random;
+import com.google.common.collect.Lists;
--- End diff --
You should also add a test where you row a few rows and then delete them
and call update statistics with and without include deleted cells and verify
that they guide point width takes into account delete cells correctly.
> UPDATE STATISTIC should collect all versions of cells
> -----------------------------------------------------
>
> Key: PHOENIX-4008
> URL: https://issues.apache.org/jira/browse/PHOENIX-4008
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Bin Shi
> Priority: Major
> Attachments: PHOENIX-4008_0918.patch
>
>
> In order to truly measure the size of data when calculating guide posts,
> UPDATE STATISTIC should taken into account all versions of cells. We should
> also be setting the max versions on the scan.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
