[ 
https://issues.apache.org/jira/browse/PHOENIX-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622517#comment-16622517
 ] 

Hadoop QA commented on PHOENIX-4874:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12940611/PHOENIX-4874_v2.patch
  against master branch at commit 91f085a902357b0a589b6367fb9c5f40b9781c8f.
  ATTACHMENT ID: 12940611

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                Arrays.asList(1, 2, 3), true, encodedBinaryData, 
Timestamp.valueOf("2006-11-03 00:00:00.001003000")));
+        verify(preparedStatement).setObject(7, 
DateUtil.parseTimestamp("2006-11-03 00:00:00.001003000"));
+                true, encodedBinaryData, Timestamp.valueOf("2006-11-03 
00:00:00.001003000"), "garbage");
+        verify(preparedStatement).setObject(7, 
DateUtil.parseTimestamp("2006-11-03 00:00:00.001003000"));
+                Arrays.asList(1, 2, 3), false, encodedBinaryData, 
Timestamp.valueOf("2006-11-03 00:00:00.001003000")));
+        verify(preparedStatement).setObject(7, 
DateUtil.parseTimestamp("2006-11-03 00:00:00.001003"));
+                Arrays.asList(1, 2, 3), true, encodedBinaryData, 
Timestamp.valueOf("2006-11-03 00:00:00.001003000"));
+        R csvRecordWithInvalidType = 
createRecord("123,NameValue,42,1:2:3,NotABoolean,"+encodedBinaryData + 
",2006-11-03 00:00:00.001003000");
+        R csvRecordWithInvalidType = 
createRecord("123,NameValue,42,1:2:3,true,"+notBase64Encoded+",2006-11-03 
00:00:00.001003000");
+                Arrays.asList(1, 2, 3), true, asciiValue, 
Timestamp.valueOf("2006-11-03 00:00:00.001003000")));

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2048//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2048//console

This message is automatically generated.

> psql doesn't support date/time with values smaller than milliseconds
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-4874
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4874
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Josh Elser
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>         Attachments: PHOENIX-4874.patch, PHOENIX-4874_v2.patch
>
>
> [https://phoenix.apache.org/tuning.html] lacks entries for 
> phoenix.query.timeFormat, phoenix.query.timestampFormat which are used by 
> psql to parse out TIME and TIMESTAMP data types.
> Add them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to