[
https://issues.apache.org/jira/browse/PHOENIX-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627810#comment-16627810
]
ASF GitHub Bot commented on PHOENIX-3955:
-----------------------------------------
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/346#discussion_r219356971
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java ---
@@ -92,8 +95,22 @@
public static final byte[] VIEW_INDEX_SEQUENCE_PREFIX_BYTES =
Bytes.toBytes(VIEW_INDEX_SEQUENCE_PREFIX);
private static final String VIEW_INDEX_ID_COLUMN_NAME = "_INDEX_ID";
public static final String PARENT_TABLE_KEY = "PARENT_TABLE";
- public static final byte[] PARENT_TABLE_KEY_BYTES =
Bytes.toBytes("PARENT_TABLE");
-
+ public static final String IS_VIEW_INDEX_TABLE_PROP_NAME =
"IS_VIEW_INDEX_TABLE";
+ public static final byte[] IS_VIEW_INDEX_TABLE_PROP_BYTES =
Bytes.toBytes(IS_VIEW_INDEX_TABLE_PROP_NAME);
+
+ public static final String IS_LOCAL_INDEX_TABLE_PROP_NAME =
"IS_LOCAL_INDEX_TABLE";
+ public static final byte[] IS_LOCAL_INDEX_TABLE_PROP_BYTES =
Bytes.toBytes(IS_LOCAL_INDEX_TABLE_PROP_NAME);
+
+ public static final String DATA_TABLE_NAME_PROP_NAME =
"DATA_TABLE_NAME";
+
+ public static final byte[] DATA_TABLE_NAME_PROP_BYTES =
Bytes.toBytes(DATA_TABLE_NAME_PROP_NAME);
+
+ // See PHOENIX-3955
--- End diff --
nit: rename to SYNCED_DATA_TABLE_AND_INDEX_PROPERTIES
> Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL properties stay in sync
> between the physical data table and index tables
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3955
> URL: https://issues.apache.org/jira/browse/PHOENIX-3955
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Chinmay Kulkarni
> Priority: Major
>
> We need to make sure that indexes inherit the REPLICATION_SCOPE,
> KEEP_DELETED_CELLS and TTL properties from the base table. Otherwise we can
> run into situations where the data was removed (or not removed) from the data
> table but was removed (or not removed) from the index. Or vice-versa. We also
> need to make sure that any ALTER TABLE SET TTL or ALTER TABLE SET
> KEEP_DELETED_CELLS statements propagate the properties to the indexes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
