[GitHub] phoenix pull request #355: support alter modify column grammar

[jaanai0]

Github user jaanai0 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/355#discussion_r220900300
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ---
    @@ -2853,12 +2687,13 @@ MetaDataMutationResult updateMutation(PTable table, 
byte[][] rowKeyMetaData,
                         return result;
                     } else {
                         table = buildTable(key, cacheKey, region, 
HConstants.LATEST_TIMESTAMP, clientVersion, false, false, null);
    -                    return new 
MetaDataMutationResult(MutationCode.TABLE_ALREADY_EXISTS, currentTime, table);
    --- End diff --
    
    `TABLE_ALREADY_EXISTS ` as positive MutationCode is wired, so I want to add 
an `OK` code to identifying success. what do you think about this?


---