[
https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637458#comment-16637458
]
ASF GitHub Bot commented on PHOENIX-4764:
-----------------------------------------
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r222447782
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTable.java
---
@@ -192,7 +192,39 @@ public static LinkType fromSerializedValue(byte
serializedValue) {
return LinkType.values()[serializedValue-1];
}
}
-
+
+ public enum TaskType {
+ DROP_CHILD_VIEWS((byte)1);
+
+ private final byte[] byteValue;
+ private final byte serializedValue;
+
+ TaskType(byte serializedValue) {
+ this.serializedValue = serializedValue;
+ this.byteValue = Bytes.toBytes(this.name());
+ }
+
+ public byte[] getBytes() {
+ return byteValue;
+ }
+
+ public byte getSerializedValue() {
+ return this.serializedValue;
+ }
+ public static TaskType getDefault() {
+ return DROP_CHILD_VIEWS;
+ }
+ public static TaskType fromToken(String token) {
+ return TaskType.valueOf(token.trim().toUpperCase());
+ }
+ public static TaskType fromSerializedValue(byte serializedValue) {
--- End diff --
Why do we need this serialization logic? @twdsilva @kadirozde
I see that it has been copied from `LinkType` and other Enum's defined
above.
> Cleanup metadata of child views for a base table that has been dropped
> ----------------------------------------------------------------------
>
> Key: PHOENIX-4764
> URL: https://issues.apache.org/jira/browse/PHOENIX-4764
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Kadir OZDEMIR
> Priority: Major
>
> When we drop a base table, we no longer drop all the child view metadata.
> Clean up the child view metadata during compaction.
> If we try to recreate a base table that was previously dropped but whose
> child view metadata wasn't cleaned up throw an exception. Add a test for
> this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
