[
https://issues.apache.org/jira/browse/PHOENIX-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641644#comment-16641644
]
Hadoop QA commented on PHOENIX-3955:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12942773/PHOENIX-3955-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
ad29c1cea8d70ef24caf12e07b5b5aa3ccf833f6.
ATTACHMENT ID: 12942773
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + alterAllSyncedPropsString.substring(0,
alterAllSyncedPropsString.length() - 1));
+ * @param propModified true if we have altered any of the properties to be
kept in sync, false otherwise
+ * @param ignoreTTL We cannot modfiy a table level property when adding a
column, so in those cases,
+ private void verifyHBaseColumnFamilyProperties(String tableName,
Connection conn, boolean propModified,
+ ddl = "ALTER TABLE " + dataTableFullName + " SET COMPACTION_ENABLED =
FALSE, CF1.MIN_VERSIONS = 1, CF2.MIN_VERSIONS = 3, " +
+
assertEquals(SQLExceptionCode.COLUMN_FAMILY_NOT_ALLOWED_FOR_PROPERTY.getErrorCode(),
e.getErrorCode());
+ + " SET COMPACTION_ENABLED = FALSE, CF.BLOCKSIZE=50000,
IMMUTABLE_ROWS = TRUE, TTL=1000";
+ + " ADD col4 integer, CF1.col5 integer,
CF2.col6 integer IN_MEMORY=true, CF1.BLOCKSIZE=50000, "
+ + " ADD col4 integer, CF1.col5 integer,
CF2.col6 integer IN_MEMORY=true, CF1.BLOCKSIZE=50000, "
+ try (HBaseAdmin admin =
conn.unwrap(PhoenixConnection.class).getQueryServices().getAdmin()) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2079//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2079//console
This message is automatically generated.
> Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL properties stay in sync
> between the physical data table and index tables
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3955
> URL: https://issues.apache.org/jira/browse/PHOENIX-3955
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-3955-4.x-HBase-1.3.patch, PHOENIX-3955.patch
>
>
> We need to make sure that indexes inherit the REPLICATION_SCOPE,
> KEEP_DELETED_CELLS and TTL properties from the base table. Otherwise we can
> run into situations where the data was removed (or not removed) from the data
> table but was removed (or not removed) from the index. Or vice-versa. We also
> need to make sure that any ALTER TABLE SET TTL or ALTER TABLE SET
> KEEP_DELETED_CELLS statements propagate the properties to the indexes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
