[ 
https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643894#comment-16643894
 ] 

ASF GitHub Bot commented on PHOENIX-4764:
-----------------------------------------

Github user kadirozde commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/359#discussion_r223796635
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
    @@ -540,6 +540,12 @@ public static boolean isSequenceTable(byte[] 
tableName) {
                     || Bytes.compareTo(tableName, SchemaUtil
                             
.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_SEQUENCE_NAME_BYTES, 
true).getName()) == 0;
         }
    +
    +    public static boolean isTaskTable(byte[] tableName) {
    --- End diff --
    
    This comment is not specific and not actionable for me. I am not sure why 
we disable stats for system tables and where we do it.


> Cleanup metadata of child views for a base table that has been dropped
> ----------------------------------------------------------------------
>
>                 Key: PHOENIX-4764
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4764
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Thomas D'Silva
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>
> When we drop a base table, we no longer drop all the child view metadata. 
> Clean up the child view metadata during compaction. 
> If we try to recreate a base table that was previously dropped but whose 
> child view metadata wasn't cleaned up throw an exception. Add a test for 
> this. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to