[GitHub] phoenix pull request #359: PHOENIX-4764 - Cleanup metadata of child views fo...

[kadirozde]

Github user kadirozde commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/359#discussion_r223875740
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -3206,6 +3219,9 @@ public void upgradeSystemTables(final String url, 
final Properties props) throws
                 try {
                     
metaConnection.createStatement().executeUpdate(getMutexDDL());
                 } catch (NewerTableAlreadyExistsException e) {} catch 
(TableAlreadyExistsException e) {}
    +            try {
    --- End diff --
    
    No sure about any value of extracting this simple try catch into a method.


---