Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/359#discussion_r223897753
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -3206,6 +3219,9 @@ public void upgradeSystemTables(final String url, 
final Properties props) throws
                 try {
                     
metaConnection.createStatement().executeUpdate(getMutexDDL());
                 } catch (NewerTableAlreadyExistsException e) {} catch 
(TableAlreadyExistsException e) {}
    +            try {
    --- End diff --
    
    Sorry for not being clear, we can refactor the method `upgradeSystemTables` 
and `createOtherSystemTables` in this one.


---

Reply via email to