Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/355#discussion_r224639651
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/KeyValueSchema.java ---
    @@ -121,7 +122,15 @@ public boolean isNull(int position, ValueBitSet 
bitSet) {
                             int nBytes = ptr.getLength();
                             b = ensureSize(b, offset, offset + nBytes);
                             System.arraycopy(ptr.get(), ptr.getOffset(), b, 
offset, nBytes);
    -                        offset += nBytes;
    +                        if (field.getMaxLength() != null && 
field.getMaxLength() > 0 ) {
    --- End diff --
    
    Is this change required to handle existing data of type char after we 
increase the length? We should only do this padding if the type is PChar right? 
Is it possible to change the length of any other fixed length data type?


---

Reply via email to