[ 
https://issues.apache.org/jira/browse/PHOENIX-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647212#comment-16647212
 ] 

Hadoop QA commented on PHOENIX-4966:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12943549/PHOENIX-4966.patch
  against master branch at commit f88f62abccb0b313f61b647178d71300cc0105aa.
  ATTACHMENT ID: 12943549

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.jdbc.SecureUserConnectionsTest

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2085//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2085//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2085//console

This message is automatically generated.

> Implement unhandledFilters in PhoenixRelation so that spark only evaluates 
> filters when required
> ------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4966
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4966
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.14.0
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>              Labels: spark
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4966.patch
>
>
> PhoenixRelation does not implement unhandledFilters so the data returned from 
> a scan is run through filters twice.
> {code}
> Project [ID#7L]
> +- Filter (((isnotnull(COL1#8) && isnotnull(ID#7L)) && (COL1#8 = test_row_1)) 
> && (ID#7L = 1))
>    +- Scan PhoenixRelation(TABLE1,localhost:50068:/hbase,false) 
> [ID#7L,COL1#8] PushedFilters: [IsNotNull(COL1), IsNotNull(ID), 
> EqualTo(COL1,test_row_1), EqualTo(ID,1)], ReadSchema: struct<ID:bigint>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to