[
https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656502#comment-16656502
]
Hadoop QA commented on PHOENIX-4981:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12944663/PHOENIX-4981-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
e07e04a54a6720a0ba8e7a806cd98a2ebc8b2d17.
ATTACHMENT ID: 12944663
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 411 javac compiler
warnings (more than the master's current 407 warnings).
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ protected ResultSet executeQuery(Connection conn, QueryBuilder
queryBuilder) throws SQLException {
+ queryBuilder.setWhereClause("a_integer = 1 AND a_string >= 'ab'
AND a_string < 'de' AND a_id = '123'");
+ queryBuilder.setWhereClause("a_integer in (2, 4) AND a_string =
'abc' AND a_id = '123'");
+ queryBuilder.setWhereClause("A_INTEGER in (1,2,3,4) AND A_STRING
in ('a', 'abc', 'de') AND A_ID = '123'");
+ queryBuilder.setWhereClause("A_INTEGER > 1 AND A_INTEGER < 4 AND
A_STRING = 'abc' AND A_ID = '123'");
+ queryBuilder.setColumns(Lists.newArrayList("B_STRING",
"B_INTEGER", "A_INTEGER", "A_STRING", "A_ID"));
+ String query = "create table " + generateUniqueName() + "
(a_integer integer not null CONSTRAINT pk PRIMARY KEY (a_integer)) SALT_BUCKETS
= 257";
+ createTestTable(getUrl(), "create table " + generateUniqueName() +
" (a_integer integer not null primary key) SALT_BUCKETS = 4",
+ protected ResultSet executeQuery(Connection conn, QueryBuilder
queryBuilder) throws SQLException {
+
JavaConverters.collectionAsScalaIterableConverter(queryBuilder.getColumns()).asScala()
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsEnabledSplitSystemCatalogIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2098//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2098//console
This message is automatically generated.
> Add tests for salted table using phoenix-spark
> ----------------------------------------------
>
> Key: PHOENIX-4981
> URL: https://issues.apache.org/jira/browse/PHOENIX-4981
> Project: Phoenix
> Issue Type: Test
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Labels: spark
> Attachments: PHOENIX-4981-4.x-HBase-1.3.patch
>
>
> See if its possible to reuse {{SaltedTableIT}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
