[
https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661559#comment-16661559
]
Hadoop QA commented on PHOENIX-4977:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12945293/PHOENIX-4977.v1.4.x-HBase-1.4.patch
against 4.x-HBase-1.4 branch at commit
0c28ea2856aa0798953b790c002644969a36ae5e.
ATTACHMENT ID: 12945293
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static final String KILL_SERVER_ON_UNHANDLED_INDEX_EXCEPTION =
"KILL_SERVER_ON_UNHANDLED_INDEX_EXCEPTION";
+ killServer =
env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_KILL_SERVER,
true);
+ public static final String INDEX_FAILURE_KILL_SERVER =
"phoenix.index.failure.unhandled.killserver";
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2102//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2102//console
This message is automatically generated.
> Make KillServerOnFailurePolicy a configurable option in
> PhoenixIndexFailurePolicy
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-4977
> URL: https://issues.apache.org/jira/browse/PHOENIX-4977
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-4977.v1.4.x-HBase-1.4.patch,
> PHOENIX-4977.v2.4.x-HBase-1.4.patch
>
>
> Currently PhoenixIndexFailurePolicy, which is the default policy, delegates
> to KillServerOnFailurePolicy. This is hardcoded in the constructor.
> Apparently this was added for a specific use case,
> BLOCK_DATA_TABLE_WRITES_ON_WRITE_FAILURE, and the policy itself derives from
> the days where forcing a RS kill was in effect the way to 'rebuild' the index
> via WAL replay.
> There are still cases where it's applicable, such as when Syscat itself
> cannot be updated in order to e.g. disable an index. However, killing the RS
> may be too aggressive for some, who might prefer a temporarily out of sync
> index to a potentially cascading wave of aborts.
> We should add a config option to control this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
