Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/397#discussion_r228699931
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableSnapshotReadsMapReduceIT.java
 ---
    @@ -66,74 +74,62 @@
       private static List<List<Object>> result;
       private long timestamp;
       private String tableName;
    +  private Job job;
    +  private Path tmpDir;
    +  private Configuration conf;
     
       @BeforeClass
       public static void doSetup() throws Exception {
           Map<String,String> props = Maps.newHashMapWithExpectedSize(1);
           setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator()));
       }
     
    -  @Test
    -  public void testMapReduceSnapshots() throws Exception {
    +  @Before
    --- End diff --
    
    Refactoring done to move common code to before method.


---

Reply via email to