[GitHub] phoenix pull request #402: PHOENIX-4981 Add tests for ORDER BY, GROUP BY and...

[twdsilva]

GitHub user twdsilva opened a pull request:

    https://github.com/apache/phoenix/pull/402

    PHOENIX-4981 Add tests for ORDER BY, GROUP BY and salted tables using…

    … phoenix-spark]
    
    @karanmehta93  thanks for the review nice catch, I modified the 
SparkContext variable to be volatile. 
    @ChinmaySKulkarni  can you please review? I refactored the AggregateIT, 
OrderByIT and SaltedIT so that it can be used to run queries using 
phoenix-spark. I created  Base*IT based on these tests with two subclasses (one 
for phoenix , one for phoenix-spark). I added a QueryBuilder to generate a SQL 
query that is used to setup the spark sql query. I also added SparkResultSet 
that implements the JDBC interface so that the existing tests can be reused 
without much changes. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twdsilva/phoenix PHOENIX-4981

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #402
    
----
commit c241e5320760384a1710839b28f2e1a2f16d38fd
Author: Thomas D'Silva <tdsilva@...>
Date:   2018-10-19T05:00:01Z

    PHOENIX-4981 Add tests for ORDER BY, GROUP BY and salted tables using 
phoenix-spark

----


---