[
https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669577#comment-16669577
]
ASF GitHub Bot commented on PHOENIX-4981:
-----------------------------------------
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229559932
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/QueryBuilder.java ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.util;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+import org.apache.phoenix.parse.HintNode;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.apache.phoenix.util.SchemaUtil.getEscapedFullColumnName;
+
+public class QueryBuilder {
+
+ private String fullTableName;
+ // regular columns that are in the select clause
+ private List<String> selectColumns = Collections.emptyList();
+
+ // columns that are required for expressions in the select clause
+ private List<String> selectExpressionColumns =
Collections.emptyList();
+ // expression string in the select clause (for eg COL1 || COL2)
+ private String selectExpression;
+ private String whereClause;
+ private String orderByClause;
+ private String groupByClause;
+ private String havingClause;
+ private HintNode.Hint hint;
+ private boolean escapeCols;
+ private boolean distinct;
+ private int limit;
--- End diff --
Can we make all member variables final and have the builder's build method
set all values in a private constructor so that we follow the builder pattern
more closely?
> Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark
> -------------------------------------------------------------------
>
> Key: PHOENIX-4981
> URL: https://issues.apache.org/jira/browse/PHOENIX-4981
> Project: Phoenix
> Issue Type: Test
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Labels: spark
> Attachments: PHOENIX-4981-4.x-HBase-1.3.patch
>
>
> See if its possible to reuse {{SaltedTableIT}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
