Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/402#discussion_r229564917
  
    --- Diff: 
phoenix-spark/src/main/java/org/apache/phoenix/spark/SparkResultSet.java ---
    @@ -0,0 +1,1056 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.spark;
    +
    +import org.apache.phoenix.exception.SQLExceptionCode;
    +import org.apache.phoenix.exception.SQLExceptionInfo;
    +import org.apache.phoenix.util.SQLCloseable;
    +import org.apache.spark.sql.Row;
    +
    +import java.io.InputStream;
    +import java.io.Reader;
    +import java.math.BigDecimal;
    +import java.net.MalformedURLException;
    +import java.net.URL;
    +import java.sql.Array;
    +import java.sql.Blob;
    +import java.sql.Clob;
    +import java.sql.Date;
    +import java.sql.NClob;
    +import java.sql.Ref;
    +import java.sql.ResultSet;
    +import java.sql.ResultSetMetaData;
    +import java.sql.RowId;
    +import java.sql.SQLException;
    +import java.sql.SQLFeatureNotSupportedException;
    +import java.sql.SQLWarning;
    +import java.sql.SQLXML;
    +import java.sql.Statement;
    +import java.sql.Time;
    +import java.sql.Timestamp;
    +import java.util.Arrays;
    +import java.util.Calendar;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * Helper class to convert a List of Rows returns from a dataset to a sql 
ResultSet
    --- End diff --
    
    nit: 'returned'


---

Reply via email to