[
https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670500#comment-16670500
]
Chinmay Kulkarni edited comment on PHOENIX-4996 at 10/31/18 6:29 PM:
---------------------------------------------------------------------
[~tdsilva] I've attached a patch with the fix for the above unit test. It was a
simple initialization error in my earlier patch, causing an NPE (just for the
test case).
was (Author: ckulkarni):
[~tdsilva] I've attached a patch with the fix for the above unit test. It was a
simple initialization error causing an NPE (just for the test case).
> Refactor PTableImpl to use Builder Pattern
> ------------------------------------------
>
> Key: PHOENIX-4996
> URL: https://issues.apache.org/jira/browse/PHOENIX-4996
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-4996.patch
>
>
> Currently _PTableImpl_ has many constructor parameters, overloaded
> constructors as well as overloaded versions of _makePTable_ which basically
> creates a new PTable itself. Because of this, constructing new PTable
> instances is becoming very difficult and error-prone. We should refactor this
> to use the builder pattern. This will improve usability and readability of
> the code at the cost of some amount of code repetition due to limitations of
> the builder pattern itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
