[
https://issues.apache.org/jira/browse/PHOENIX-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689772#comment-16689772
]
Geoffrey Jacoby commented on PHOENIX-5024:
------------------------------------------
This patch is just taking PostDDLCompiler and applying IntelliJ's "Convert
Anonymous to Inner" refactor to the three giant anonymous inner classes there.
I left untouched a small anonymous subclass of MutationState that just overrode
a single small accessor method. No logic was changed (though as future work
some Extract Methods would be good...)
phoenix-core tests all passed locally except for SplitIT, which is a known test
bug that Thomas fixed last night in PHOENIX-5021.
[~vincentpoon] [~tdsilva]
> Cleanup anonymous inner classes in PostDDLCompiler
> --------------------------------------------------
>
> Key: PHOENIX-5024
> URL: https://issues.apache.org/jira/browse/PHOENIX-5024
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Minor
> Attachments: PHOENIX-5024-4.x-HBase-1.4.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)