[ 
https://issues.apache.org/jira/browse/PHOENIX-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690204#comment-16690204
 ] 

Hadoop QA commented on PHOENIX-4955:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12948562/PHOENIX-4955.patch
  against master branch at commit 7eb41b0b261ae6168c7d09585eb1754bca4fc98f.
  ATTACHMENT ID: 12948562

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectAutoCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2151//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2151//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2151//console

This message is automatically generated.

> PhoenixIndexImportDirectMapper undercounts failed records
> ---------------------------------------------------------
>
>                 Key: PHOENIX-4955
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4955
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0, 5.0.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4955.patch
>
>
> PhoenixIndexImportDirectMapper's map function has a catch block for 
> SQLExceptions raised when committing writes to the index being built or 
> rebuilt. However, it only increments the FAILED_RECORDS counter by 1 when an 
> exception occurs, regardless of how large the batch size being committed is. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to