[
https://issues.apache.org/jira/browse/PHOENIX-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695330#comment-16695330
]
Hadoop QA commented on PHOENIX-4765:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12949102/PHOENIX-4765-v2-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
cfcf615d98c682df3b60aa7bd82c6706082bdac2.
ATTACHMENT ID: 12949102
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " (TENANT_ID VARCHAR NOT NULL, PK1 VARCHAR NOT NULL,
V1 VARCHAR CONSTRAINT PK " +
+ * Ensure that we cannot add a column to a base table if
QueryServices.BLOCK_METADATA_CHANGES_REQUIRE_PROPAGATION
+ String fullTableName =
SchemaUtil.getTableName(generateUniqueName(), generateUniqueName());
+ String fullViewName =
SchemaUtil.getTableName(generateUniqueName(), generateUniqueName());
+ this.allowSystemCatalogRollback =
config.getBoolean(QueryServices.ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK,
+ // 2) if allowSystemCatalogRollback is true we try to lock
the parent table to prevent it
+ logger.error("Unable to lock parentTableKey
"+Bytes.toStringBinary(parentTableKey));
+ // if allowSystemCatalogRollback is true and we
can't lock the parentTableKey (because
+ // SYSTEM.CATALOG already split) return
UNALLOWED_TABLE_MUTATION so that the client
+ // When we drop a view we first drop the view metadata and
then drop the parent->child linking row
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SkipScanAfterManualSplitIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2161//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2161//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2161//console
This message is automatically generated.
> Add client and server side config property to enable rollback of splittable
> System Catalog if required
> ------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4765
> URL: https://issues.apache.org/jira/browse/PHOENIX-4765
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Blocker
> Attachments: PHOENIX-4765-v2-4.x-HBase-1.3.patch,
> PHOENIX-4765-v2.patch
>
>
> After the server has been upgraded we will have a client and server side
> config property that will allow us to rollback the upgrade if required. This
> config will:
> 1. Continue storing parent column metadata along with a child view
> 2. Disallow metadata changes to a base table that require being propagated to
> child views.
> 3. Prevent SYSTEM.CATALOG from splitting.
> If the client is older than the server we also disallow metadata changes to a
> base table with child views since we no longer lock the parent on the server
> side. This is handled on the client side as part of PHOENIX-3534.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
