Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/406#discussion_r236472049
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ---
    @@ -530,6 +530,10 @@ private static PName newPName(byte[] keyBuffer, int 
keyOffset, int keyLength) {
         private int maxIndexesPerTable;
         private boolean isTablesMappingEnabled;
     
    +    // this flag denotes that we will continue to write parent table 
column metadata while creating
    +    // a child view and also block metadata changes that were previously 
propagated to children
    +    // before 4.15, so that we can rollback the upgrade to 4.15 if required
    +    private boolean allowSystemCatalogRollback;
    --- End diff --
    
    Had a conversation offline with Thomas and the underlying point in my 
comment above is already being addressed. Thanks @twdsilva.


---

Reply via email to