[ 
https://issues.apache.org/jira/browse/PHOENIX-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703821#comment-16703821
 ] 

James Taylor commented on PHOENIX-5044:
---------------------------------------

I'm all for getting rid of code that's not useful, but can some perf testing be 
done on a real cluster? The difference in perf between server-side vs pure 
client-side don't make sense to me. How about doing a Pherf run?

For index building in particular, turning on server-side updates should in 
theory be a big win. Deadlocks would not be an issue given the high/low 
priority queues we use. Best case would be if PHOENIX-4746 were implemented so 
that the index could be presplit.

> Remove server side mutation code from Phoenix
> ---------------------------------------------
>
>                 Key: PHOENIX-5044
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5044
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Major
>         Attachments: 5044-looksee-v2.txt, 5044-looksee-v3.txt, 
> 5044-looksee.txt
>
>
> This is for *discussion*. Perhaps controversial.
> It generally seems to be a bad - if well-intentioned - idea to trigger 
> mutations directly from the server. The main causes are UPSERT SELECT for the 
> same table and DELETE FROM.
> IMHO, it's generally better to allow the client to handle this. There might 
> be larger network overhead, but we get better chunking, better pacing, and 
> behavior more in line with how HBase was intended to work.
> In PHOENIX-5026 I introduced a flag to disable server triggered mutations in 
> the two cases mentioned above. I now think it's better to just remove the 
> server code and also perform these from the client.
> (Note that server side reads - aggregation, filters, etc - are still insanely 
> valuable and not affected by this)
> Let's discuss.
> [~tdsilva], [[email protected]], [~jamestaylor], [~vincentpoon], [~gjacoby]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to