[
https://issues.apache.org/jira/browse/PHOENIX-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709303#comment-16709303
]
Hadoop QA commented on PHOENIX-5025:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12950597/PHOENIX-5025.master.patch
against master branch at commit 1ab08c72620962268d58d132a6b5bb3629b2656f.
ATTACHMENT ID: 12950597
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static final String viewFileName = "/tmp/" +
OrphanViewTool.fileName[OrphanViewTool.VIEW];
+ private static final String physicalLinkFileName = "/tmp/" +
OrphanViewTool.fileName[OrphanViewTool.PHYSICAL_TABLE_LINK];
+ private static final String parentLinkFileName = "/tmp/" +
OrphanViewTool.fileName[OrphanViewTool.PARENT_TABLE_LINK];
+ private static final String childLinkFileName = "/tmp/" +
OrphanViewTool.fileName[OrphanViewTool.CHILD_TABLE_LINK];
+ private static final String createBaseTableSecondPartDDL = "(%s PK2
VARCHAR NOT NULL, V1 VARCHAR, V2 VARCHAR " +
+ private static final String countChildLinksQuery = "SELECT COUNT(*) FROM "
+ SYSTEM_CHILD_LINK_NAME +
+ private static final String countParentLinksQuery = "SELECT COUNT(*) FROM
" + SYSTEM_CATALOG_NAME +
+ private static final String countPhysicalLinksQuery = "SELECT COUNT(*)
FROM " + SYSTEM_CATALOG_NAME +
+ @Parameters(name="OrphanViewToolIT_multiTenant={0}, columnEncoded={1}") //
name is used by failsafe as file name in reports
+ private void deleteRowsFrom(Connection connection, String systemTableName,
String baseTableSchema,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2187//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2187//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2187//console
This message is automatically generated.
> Tool to clean up orphan views
> -----------------------------
>
> Key: PHOENIX-5025
> URL: https://issues.apache.org/jira/browse/PHOENIX-5025
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-5025.master.patch
>
>
> A view without its base table is an orphan view. Since views are virtual
> tables and their data is stored in their base tables, they are useless when
> they become orphan. A base table can have child views, grandchild views and
> so on. Due to some reasons/bugs, when a base table was dropped, its views
> were not not properly cleaned up in the past. For example, the drop table
> code did not support cleaning up grandchild views. This has been recently
> fixed by PHOENIX-4764. Although PHOENIX-4764 prevents new orphan views due to
> table drop operations, it does not clean up existing orphan views. It is also
> believed that when the system catalog table was split due to a bug in the
> past, it also contributed to creating orphan views as Phoenix did not support
> splittable system catalog. Therefore, Phoenix needs a tool to clean up orphan
> views.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
