Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/410#discussion_r238930264
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java ---
@@ -250,7 +250,103 @@ public void testWithLoggingOFF() throws Exception{
assertFalse(foundQueryLog);
conn.close();
}
-
+
+ @Test
+ //DROP Table statement should be always logged.
+ public void testDropTableStatement() throws Exception{
--- End diff --
Also can you test a scenario with multiple drop/alter statements issued
together. What happens if the RingBuffer is full and we are trying to add to
it, does it block and wait OR it drops it (in that case this is not complete)?
---
