[
https://issues.apache.org/jira/browse/PHOENIX-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715370#comment-16715370
]
Hadoop QA commented on PHOENIX-4993:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12951211/PHOENIX-4993-4.x-HBase-1.3.01.patch
against 4.x-HBase-1.3 branch at commit
303fff09466bad5ab1e9aa0707c27d960fa5632d.
ATTACHMENT ID: 12951211
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ setUpTestDriver(new
ReadOnlyProps(serverProps.entrySet().iterator()), new
ReadOnlyProps(clientProps.entrySet().iterator()));
+ stmt.executeUpdate("UPSERT INTO " + tableName +
" VALUES('" + getRandomOrgId(maxOrgId) + "'," + i +","+ (i + 1) + ","+ (i + 2)
+")");
+ String createTableSql = "CREATE TABLE " + tableName + "(org_id VARCHAR
NOT NULL PRIMARY KEY, v1 INTEGER, v2 INTEGER, v3 INTEGER) VERSIONS=1 SPLIT ON
('" + ORG_PREFIX + "-" + noOfOrgs / 2 + "')";
+ System.out.println("Split completed.
number of regions are region = " +
admin.getTableRegions(Bytes.toBytes(tableName)).size());
+ System.out.println("Region server
aborted " + regionServer.isAborted() + ", " + regionServer.isStopped() + ", "
+regionServer.isStopping());
+ regionServerKilled =
regionServer.isAborted() || regionServer.isStopped() ||
regionServer.isStopping();
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2198//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2198//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2198//console
This message is automatically generated.
> Data table region should not close RS level shared/cached connections like
> IndexWriter, RecoveryIndexWriter
> -----------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4993
> URL: https://issues.apache.org/jira/browse/PHOENIX-4993
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.0
> Reporter: Kiran Kumar Maturi
> Assignee: Kiran Kumar Maturi
> Priority: Major
> Attachments: PHOENIX-4993-4.x-HBase-1.3.01.patch
>
>
> Issue is related to Region Server being killed when one region is closing and
> another region is trying to write index updates.
> When the data table region closes it will close region server level
> cached/shared connections and it could interrupt other region
> index/index-state update.
> -- Region1: Closing
> {code:java}
> TrackingParallellWriterIndexCommitter#stop() {
> this.retryingFactory.shutdown();
> this.noRetriesFactory.shutdown();
> }{code}
> closes the cached connections calling
> CoprocessorHConnectionTableFactory#shutdown() in ServerUtil.java
>
> --Region2: Writing index updates
> Index updates fail as connections are closed, which leads to
> RejectedExecutionException/Connection being null. This triggers
> PhoenixIndexFailurePolicy#handleFailureWithExceptions that tries to get the
> the syscat table using the cached connections. Here it will not be able to
> reach to SYSCAT , so we will trigger KillServreFailurePolicy.
> CoprocessorHConnectionTableFactory#getTable()
>
>
> {code:java}
> if (connection == null || connection.isClosed()) {
> throw new IllegalArgumentException("Connection is null or closed.");
> }{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
