Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/418#discussion_r242673126
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/OmidTransactionalProcessor.java
---
@@ -17,13 +17,16 @@
*/
package org.apache.phoenix.coprocessor;
-import org.apache.hadoop.hbase.coprocessor.BaseRegionObserver;
+import org.apache.omid.transaction.OmidSnapshotFilter;
+import org.apache.phoenix.transaction.OmidTransactionProvider;
public class OmidTransactionalProcessor extends DelegateRegionObserver {
public OmidTransactionalProcessor() {
- super(new BaseRegionObserver());
+ // Hack for testing - retrieves the commit table client from the
singleton OmidTransactionProvider
+ // TODO: use real commit table and get port from config
--- End diff --
No, I think it's ok as-is.
---
