Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r243703560
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java ---
@@ -88,4 +88,10 @@
* @return
*/
boolean requiresFinalEvaluation();
+
--- End diff --
As James said before its not clear to me why you need this new function,
can just use ExpressionUtil.isConstant() ?
Your implementation returns true by default and is false only for
AggregateFunction, RandomFunction and SequenceValueExpression for which
ExpressionUtil.isConstant() should also return false, right?
---
