joshelser commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r245088884
########## File path: pom.xml ########## @@ -0,0 +1,553 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.phoenix</groupId> + <artifactId>phoenix-queryserver</artifactId> + <version>4.15.0-HBase-1.4-SNAPSHOT</version> + <packaging>pom</packaging> + <name>Phoenix Query Server</name> + + <licenses> + <license> + <name>The Apache Software License, Version 2.0</name> + <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url> + <distribution>repo</distribution> + <comments/> + </license> + </licenses> + + <organization> + <name>Apache Software Foundation</name> + <url>http://www.apache.org</url> + </organization> + + <modules> + <module>queryserver</module> + <module>queryserver-client</module> + </modules> + + <repositories> + <repository> + <id>apache release</id> + <url>https://repository.apache.org/content/repositories/releases/</url> + </repository> + </repositories> + + <scm> + <connection>scm:git:https://gitbox.apache.org/repos/asf/phoenix-queryserver.git</connection> + <url>https://gitbox.apache.org/repos/asf/phoenix-queryserver.git</url> + <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/phoenix-queryserver.git</developerConnection> + </scm> + + <properties> + <!-- General Properties --> + <top.dir>${project.basedir}</top.dir> + + <!-- Hadoop Versions --> + <hbase.version>1.4.0</hbase.version> + <hadoop-two.version>2.7.5</hadoop-two.version> + + <!-- Dependency versions --> + <commons-cli.version>1.2</commons-cli.version> + <hive.version>1.2.1</hive.version> Review comment: I am 99% sure that this isn't used anywhere. Can you make sure we're only including properties that are used? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
