Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/424#discussion_r245188153
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/expression/BaseExpression.java ---
    @@ -255,4 +255,15 @@ public boolean requiresFinalEvaluation() {
             return false;
         }
     
    +    @Override
    +    public boolean isCloneExpression()  {
    +       return isCloneExpressionByDeterminism(this);
    +    }
    +
    +    protected static boolean isCloneExpressionByDeterminism(BaseExpression 
expression) {
    --- End diff --
    
    +1 LGTM


---

Reply via email to