[ 
https://issues.apache.org/jira/browse/PHOENIX-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736009#comment-16736009
 ] 

ASF GitHub Bot commented on PHOENIX-5059:
-----------------------------------------

Github user jmahonin commented on the issue:

    https://github.com/apache/phoenix/pull/423
  
    @twdsilva Very impressive work, well done!
    
    A few questions:
    - Does this break compatibility with previous Spark versions? i.e., Spark 
2.3.x wouldn't be binary-compatible with Phoenix 5.1.x (or whatever the next 
version ends up being)
    
    - It seems like much of the boiler-plate MR code has been replicated 
yet-again into this new integration. The overall structure makes sense here, 
but I'm wondering if some of that code shouldn't live in phoenix-spark at all?


> Use the Datasource v2 api in the spark connector
> ------------------------------------------------
>
>                 Key: PHOENIX-5059
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5059
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>         Attachments: PHOENIX-5059-wip.patch
>
>
> Switching to the v2 api will enable pushing downing limits/aggregations and 
> more in the future.
> https://issues.apache.org/jira/browse/SPARK-15689



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to