BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r246163557
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/NamespaceEnabledStatsCollectorIT.java
##########
@@ -17,48 +17,48 @@
*/
package org.apache.phoenix.end2end;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.Map;
-
+import com.google.common.collect.Maps;
import org.apache.phoenix.query.QueryServices;
-import org.apache.phoenix.schema.stats.StatsCollectorIT;
+import org.apache.phoenix.schema.stats.BaseStatsCollectorIT;
import org.apache.phoenix.util.ReadOnlyProps;
-import org.apache.phoenix.util.TestUtil;
import org.junit.BeforeClass;
-import org.junit.runners.Parameterized.Parameters;
+import org.junit.runners.Parameterized;
-import com.google.common.collect.Maps;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Map;
+
+import static
org.apache.phoenix.query.QueryServicesOptions.DEFAULT_TASK_HANDLING_INTERVAL_MS;
-public class SysTableNamespaceMappedStatsCollectorIT extends StatsCollectorIT {
+public class NamespaceEnabledStatsCollectorIT extends BaseStatsCollectorIT {
- public SysTableNamespaceMappedStatsCollectorIT(boolean mutable, String
transactionProvider,
- boolean userTableNamespaceMapped, boolean columnEncoded) {
- super(mutable, transactionProvider, userTableNamespaceMapped,
columnEncoded);
+ public NamespaceEnabledStatsCollectorIT(boolean userTableNamespaceMapped,
boolean collectStatsOnSnapshot) {
+ super(userTableNamespaceMapped, collectStatsOnSnapshot);
}
- @Parameters(name =
"mutable={0},transactionProvider={1},isUserTableNamespaceMapped={2},columnEncoded={3}")
- public static Collection<Object[]> data() {
- return TestUtil.filterTxParamData(Arrays.asList(
- new Object[][] {
- { true, "TEPHRA", false, false }, { true, "TEPHRA", false,
true },
- { true, "OMID", false, false },
- }), 1);
+ @Parameterized.Parameters(name =
"userTableNamespaceMapped={0},collectStatsOnSnapshot={1}")
+ public static Collection<Object[]> provideData() {
Review comment:
The same question for how provideData being used. As the above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
