BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r246222579
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
##########
@@ -154,7 +154,8 @@
public enum SchemaType {
TABLE,
- QUERY;
+ QUERY,
+ UPDATE_STATS
Review comment:
I checked the code. THE QUERY is generally used for phoenix map reduce jobs.
I doubt that we should reuse SchemaType and add UPDATE_STATS here, because now
for every place where it checks whether schema type is QUERY you might need to
check if it can be applied to UPDATE_STATS too, as UPDATE_STATS is also select
statement and MR job. I prefer to add one more new property in configuration to
indicate whether this is UPDATE STATS or not instead of adding a new
UPDATE_STATS enum type to SchemaType.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
