karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r246260715
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/NamespaceDisabledStatsCollectorIT.java
##########
@@ -15,24 +15,31 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.phoenix.end2end;
+import org.apache.phoenix.schema.stats.BaseStatsCollectorIT;
+import org.junit.runners.Parameterized;
+
import java.util.Arrays;
import java.util.Collection;
-import org.apache.phoenix.schema.stats.StatsCollectorIT;
-import org.junit.runners.Parameterized.Parameters;
+public class NamespaceDisabledStatsCollectorIT extends BaseStatsCollectorIT {
-public class NonColumnEncodedImmutableNonTxStatsCollectorIT extends
StatsCollectorIT {
-
- public NonColumnEncodedImmutableNonTxStatsCollectorIT(boolean mutable,
String transactionProvider,
- boolean userTableNamespaceMapped, boolean columnEncoded) {
- super(mutable, transactionProvider, userTableNamespaceMapped,
columnEncoded);
+ public NamespaceDisabledStatsCollectorIT(boolean userTableNamespaceMapped,
boolean collectStatsOnSnapshot) {
+ super(userTableNamespaceMapped, collectStatsOnSnapshot);
}
- @Parameters(name =
"mutable={0},transactionProvider={1},isUserTableNamespaceMapped={2},columnEncoded={3}")
- public static Collection<Object[]> data() {
+ @Parameterized.Parameters(name =
"userTableNamespaceMapped={0},collectStatsOnSnapshot={1}")
+ public static Collection<Object[]> provideData() {
return Arrays.asList(
- new Object[][] { { false, null, false, false }, { false, null,
true, false } });
+ new Object[][] {
+ // Collect stats on snapshots using
UpdateStatisticsTool
+ { false, true },
Review comment:
The disabled here is for namespaces and not stats, hence it is that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
