karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r247218618
##########
File path:
phoenix-pig/src/main/java/org/apache/phoenix/pig/util/PhoenixPigSchemaUtil.java
##########
@@ -62,7 +62,7 @@ public static ResourceSchema getResourceSchema(final
Configuration configuration
Preconditions.checkNotNull(sqlQuery, "No Sql Query exists
within the configuration");
final SqlQueryToColumnInfoFunction function = new
SqlQueryToColumnInfoFunction(configuration);
columns = function.apply(sqlQuery);
- } else {
+ } else if (SchemaType.TABLE.equals(schemaType)) {
Review comment:
Yes I agree that we should standardize it. There is no pre-defined standard
here and both of them work in theory. Any particular prefs you suggest for one
over other? Also can you point me to other location (if you remember)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
