[
https://issues.apache.org/jira/browse/PHOENIX-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741772#comment-16741772
]
Hadoop QA commented on PHOENIX-3623:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12954759/batchResult.patch
against master branch at commit 3bd426f10337b6e109ab7394bd4a4023039fd0e8.
ATTACHMENT ID: 12954759
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.MutableRollbackIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalMutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalImmutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.FlappingTransactionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ImmutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.TxCheckpointIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2241//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2241//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2241//console
This message is automatically generated.
> Integrate Omid with Phoenix
> ---------------------------
>
> Key: PHOENIX-3623
> URL: https://issues.apache.org/jira/browse/PHOENIX-3623
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Ohad Shacham
> Assignee: Yonatan Gottesman
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: 4.x-HBase-1.2.patch, 4.x-HBase-1.3.patch,
> 4.x-HBase-1.4.patch, batchResult.patch, master.patch
>
>
> The purpose of this Jira is to propose a work plan for connecting Omid to
> Phoenix.
> Each task of the following will be handled in a seperate sub Jira. Subtasks
> 4.* are related to augmenting Omid to support features required by Phoenix
> and therefore, their corresponding Jiras will appear under Omid and not under
> Phoenix.
> Each task is completed by a commit.
> Task 1: Adding transaction abstraction layer (TAL) - Currently Tephra calls
> are integrated inside Phoenix code. Therefore, in order to support both Omid
> and Tephra, we need to add another abstraction layer that later-on will be
> connected to both Tephra and Omid. The first tasks is to define such an
> interface.
> Task 2: Implement TAL functionality for Tephra.
> Task 3: Refactor Phoenix to use TAL instead of direct calls to Tephra.
> Task 4: Implement Omid required features for Phoenix:
> Task 4.1: Add checkpoints to Omid. A checkpoint is a point in a transaction
> where every write occurs after the checkpoint is not visible by the
> transaction. Explanations for this feature can be seen in [TEPHRA-96].
> Task 4.2: Add an option to mark a key as non-conflicting. The motivation is
> to reduce the size of the write set needed by the transaction manager upon
> commit as well as reduce the conflict detection work.
> Task 4.3: Add support for transactions that never abort. Such transactions
> will only make other inflight transactions abort and will abort only in case
> of a transaction manager failure.
> These transactions are needed for ‘create index’ and the scenario was
> discussed in [TEPHRA-157] and [PHOENIX-2478]. Augmenting Omid with this kind
> of transactions was also discussed in [OMID-56].
> Task 4.4: Add support for returning multiple versions in a scan. The use case
> is described in [TEPHRA-134].
> Task 4.5: Change Omid's timestamp mechanism to return real time based
> timestamp, while keeping monotonicity.
> Task 5: Implement TAL functionality for Omid.
> Task 6: Implement performance tests and tune Omid for Phoenix use. This task
> requires understanding of common usage scenarios in Phoenix as well as
> defining the tradeoff between throughput and latency.
> Could you please review the proposed work plan?
> Also, could you please let me know whether I missed any augmentation needed
> for Omid in order to support Phoenix operations?
> I opened a jira [OMID-82] that encapsulates all Omid related development for
> Phoenix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
