dbwong commented on a change in pull request #425: PHOENIX-5069 Use
asynchronous refresh to provide non-blocking Phoenix Stats Client Cache
URL: https://github.com/apache/phoenix/pull/425#discussion_r248470101
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/GuidePostsInfo.java
##########
@@ -95,15 +95,17 @@ public GuidePostsInfo(List<Long> byteCounts,
ImmutableBytesWritable guidePosts,
this.guidePostsCount = guidePostsCount;
this.rowCounts = Longs.toArray(rowCounts);
this.byteCounts = Longs.toArray(byteCounts);
- int estimatedSize = SizedUtil.OBJECT_SIZE
+ this.gpTimestamps = Longs.toArray(updateTimes);
+ // Those Java equivalents of sizeof() in C/C++, mentioned on the Web,
might be overkilled here.
+ int estimatedSize = SizedUtil.OBJECT_SIZE
+ SizedUtil.IMMUTABLE_BYTES_WRITABLE_SIZE +
guidePosts.getLength() // guidePosts
+ SizedUtil.INT_SIZE // maxLength
+ SizedUtil.INT_SIZE // guidePostsCount
+ SizedUtil.ARRAY_SIZE + this.rowCounts.length *
SizedUtil.LONG_SIZE // rowCounts
+ SizedUtil.ARRAY_SIZE + this.byteCounts.length *
SizedUtil.LONG_SIZE // byteCounts
+ + SizedUtil.ARRAY_SIZE + this.gpTimestamps.length *
SizedUtil.LONG_SIZE // gpTimestamps
+ SizedUtil.INT_SIZE; // estimatedSize
this.estimatedSize = estimatedSize;
Review comment:
nit: remove unused intermediate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
