vincentpoon commented on a change in pull request #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1#discussion_r248912853
########## File path: pom.xml ########## @@ -0,0 +1,778 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <modelVersion>4.0.0</modelVersion> + <groupId>org.apache.phoenix</groupId> + <artifactId>phoenix</artifactId> + <version>1.0.0-SNAPSHOT</version> + <packaging>pom</packaging> + <name>Apache Phoenix Connectors</name> + <description>Connectors for third party libraries to access data stored in Phoenix/HBase</description> + + <licenses> + <license> + <name>The Apache Software License, Version 2.0</name> + <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url> + <distribution>repo</distribution> + <comments/> + </license> + </licenses> + + <organization> + <name>Apache Software Foundation</name> + <url>http://www.apache.org</url> + </organization> + + <modules> + <module>phoenix-flume</module> + <module>phoenix-kafka</module> + <module>phoenix-pig</module> + <module>phoenix-spark</module> + <module>phoenix-hive</module> + </modules> + + <repositories> + <repository> + <id>apache release</id> + <url>https://repository.apache.org/content/repositories/releases/</url> + </repository> + </repositories> + + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>14</version> + </parent> + + <scm> + <connection>scm:git:http://gitbox.apache.org/repos/asf/phoenix-connectors.git</connection> + <url>https://gitbox.apache.org/repos/asf/phoenix-connectors.git</url> + <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/phoenix-connectors.git</developerConnection> + </scm> + + <properties> + <!-- Phoenix Version --> + <phoenix.version>4.15.0-HBase-1.4-SNAPSHOT</phoenix.version> + <!-- Hadoop Versions --> + <hbase.version>1.4.0</hbase.version> + <hadoop-two.version>2.7.5</hadoop-two.version> + + <!-- General Properties --> + <test.output.tofile>true</test.output.tofile> + <top.dir>${project.basedir}</top.dir> + + + <!-- Dependency versions --> + <hive.version>1.2.1</hive.version> + <hadoop.version>2.7.1</hadoop.version> + <pig.version>0.13.0</pig.version> + <log4j.version>1.2.17</log4j.version> + <disruptor.version>3.3.6</disruptor.version> + <slf4j.version>1.6.4</slf4j.version> + <commons-csv.version>1.0</commons-csv.version> + <guava.version>13.0.1</guava.version> + <flume.version>1.4.0</flume.version> + <kafka.version>0.9.0.0</kafka.version> + <spark.version>2.4.0</spark.version> + <scala.version>2.11.8</scala.version> + <scala.binary.version>2.11</scala.binary.version> + <mockito-all.version>1.8.5</mockito-all.version> + <junit.version>4.12</junit.version> + + <!-- Plugin versions --> + <maven-eclipse-plugin.version>2.9</maven-eclipse-plugin.version> + <maven-build-helper-plugin.version>1.9.1</maven-build-helper-plugin.version> + <maven-surefire-plugin.version>2.20</maven-surefire-plugin.version> + <maven-failsafe-plugin.version>2.20</maven-failsafe-plugin.version> + + <maven-dependency-plugin.version>2.1</maven-dependency-plugin.version> + <maven.assembly.version>2.5.2</maven.assembly.version> + + <!-- Plugin options --> + <numForkedUT>8</numForkedUT> + <numForkedIT>7</numForkedIT> + <it.failIfNoSpecifiedTests>false</it.failIfNoSpecifiedTests> + <surefire.failIfNoSpecifiedTests>false</surefire.failIfNoSpecifiedTests> + + <!-- Set default encoding so multi-byte tests work correctly on the Mac --> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> + <curator.version>2.12.0</curator.version> + + </properties> + + <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> + <version>3.0</version> + <configuration> + <source>1.7</source> + <target>1.7</target> + </configuration> + </plugin> + <!--This plugin's configuration is used to store Eclipse m2e settings + only. It has no influence on the Maven build itself. --> + <plugin> + <groupId>org.eclipse.m2e</groupId> + <artifactId>lifecycle-mapping</artifactId> + <version>1.0.0</version> + <configuration> + <lifecycleMappingMetadata> + <pluginExecutions> + <pluginExecution> + <pluginExecutionFilter> + <groupId>org.antlr</groupId> + <artifactId>antlr3-maven-plugin</artifactId> + <versionRange>[3.5,)</versionRange> + <goals> + <goal>antlr</goal> + </goals> + </pluginExecutionFilter> + <action> + <ignore /> + </action> + </pluginExecution> + </pluginExecutions> + </lifecycleMappingMetadata> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-install-plugin</artifactId> + <version>2.5.2</version> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-eclipse-plugin</artifactId> + <version>${maven-eclipse-plugin.version}</version> + </plugin> + <plugin> + <artifactId>maven-assembly-plugin</artifactId> + <version>${maven.assembly.version}</version> + </plugin> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + <!-- Avoid defining exclusions in pluginManagement as they are global. + We already inherit some from the ASF parent pom. --> + </plugin> + <!-- We put slow-running tests into src/it and run them during the + integration-test phase using the failsafe plugin. This way + developers can run unit tests conveniently from the IDE or via + "mvn package" from the command line without triggering time + consuming integration tests. --> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>build-helper-maven-plugin</artifactId> + <version>${maven-build-helper-plugin.version}</version> + <executions> + <execution> + <id>add-test-source</id> + <phase>validate</phase> + <goals> + <goal>add-test-source</goal> + </goals> + <configuration> + <sources> + <source>${basedir}/src/it/java</source> + </sources> + </configuration> + </execution> + <execution> + <id>add-test-resource</id> + <phase>validate</phase> + <goals> + <goal>add-test-resource</goal> + </goals> + <configuration> + <resources> + <resource> + <directory>${basedir}/src/it/resources</directory> + </resource> + </resources> + </configuration> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-failsafe-plugin</artifactId> + <version>${maven-failsafe-plugin.version}</version> + <executions> + <execution> + <id>ParallelStatsEnabledTest</id> + <configuration> + <encoding>UTF-8</encoding> + <forkCount>${numForkedIT}</forkCount> + <runOrder>alphabetical</runOrder> + <reuseForks>true</reuseForks> + <runOrder>alphabetical</runOrder> + <!--parallel>methods</parallel> + <threadCount>20</threadCount--> + <argLine>-Xmx2000m -XX:MaxPermSize=256m -Djava.security.egd=file:/dev/./urandom "-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}" -XX:NewRatio=4 -XX:SurvivorRatio=8 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+DisableExplicitGC -XX:+UseCMSInitiatingOccupancyOnly -XX:+CMSClassUnloadingEnabled -XX:+CMSScavengeBeforeRemark -XX:CMSInitiatingOccupancyFraction=68 -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/</argLine> + <redirectTestOutputToFile>${test.output.tofile}</redirectTestOutputToFile> + <shutdown>kill</shutdown> + <testSourceDirectory>${basedir}/src/it/java</testSourceDirectory> + <groups>org.apache.phoenix.end2end.ParallelStatsEnabledTest</groups> + </configuration> + <goals> + <goal>integration-test</goal> + <goal>verify</goal> + </goals> + </execution> + <execution> + <id>ParallelStatsDisabledTest</id> + <configuration> + <encoding>UTF-8</encoding> + <forkCount>${numForkedIT}</forkCount> + <runOrder>alphabetical</runOrder> + <reuseForks>true</reuseForks> + <runOrder>alphabetical</runOrder> + <!--parallel>methods</parallel> + <threadCount>20</threadCount--> + <!-- We're intermittantly hitting this assertion when running in parallel: + Caused by: java.lang.AssertionError: we should never remove a different context + at org.apache.hadoop.hbase.regionserver.HRegion$RowLockContext.cleanUp(HRegion.java:5206) + at org.apache.hadoop.hbase.regionserver.HRegion$RowLockImpl.release(HRegion.java:5246) + at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.doGetTable(MetaDataEndpointImpl.java:2898) + at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.doGetTable(MetaDataEndpointImpl.java:2835) + at org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(MetaDataEndpointImpl.java:490) --> + <!--enableAssertions>false</enableAssertions--> + <argLine>-Xmx3000m -XX:MaxPermSize=256m -Djava.security.egd=file:/dev/./urandom "-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}" -XX:NewRatio=4 -XX:SurvivorRatio=8 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+DisableExplicitGC -XX:+UseCMSInitiatingOccupancyOnly -XX:+CMSClassUnloadingEnabled -XX:+CMSScavengeBeforeRemark -XX:CMSInitiatingOccupancyFraction=68 -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/</argLine> + <redirectTestOutputToFile>${test.output.tofile}</redirectTestOutputToFile> + <shutdown>kill</shutdown> + <testSourceDirectory>${basedir}/src/it/java</testSourceDirectory> + <groups>org.apache.phoenix.end2end.ParallelStatsDisabledTest</groups> + </configuration> + <goals> + <goal>integration-test</goal> + <goal>verify</goal> + </goals> + </execution> + <execution> + <id>HBaseManagedTimeTests</id> + <configuration> + <encoding>UTF-8</encoding> + <forkCount>${numForkedIT}</forkCount> + <runOrder>alphabetical</runOrder> + <reuseForks>true</reuseForks> + <argLine>-enableassertions -Xmx2000m -XX:MaxPermSize=128m -Djava.security.egd=file:/dev/./urandom "-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}" -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/</argLine> + <redirectTestOutputToFile>${test.output.tofile}</redirectTestOutputToFile> + <testSourceDirectory>${basedir}/src/it/java</testSourceDirectory> + <groups>org.apache.phoenix.end2end.HBaseManagedTimeTest</groups> + <shutdown>kill</shutdown> + </configuration> + <goals> + <goal>integration-test</goal> + <goal>verify</goal> + </goals> + </execution> + </executions> + </plugin> + <plugin> + <artifactId>maven-dependency-plugin</artifactId> + <version>${maven-dependency-plugin.version}</version> + <executions> + <execution> + <id>create-mrapp-generated-classpath</id> + <phase>generate-test-resources</phase> + <goals> + <goal>build-classpath</goal> + </goals> + <configuration> + <outputFile>${project.build.directory}/classes/mrapp-generated-classpath + </outputFile> + </configuration> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>2.4.3</version> + </plugin> + <plugin> + <!-- Allows us to get the apache-ds bundle artifacts --> + <groupId>org.apache.felix</groupId> + <artifactId>maven-bundle-plugin</artifactId> + <version>2.5.3</version> + </plugin> + </plugins> + </pluginManagement> + + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <version>2.13</version> + <executions> + <execution> + <id>validate</id> + <phase>validate</phase> + <configuration> + <skip>true</skip> + <configLocation>${top.dir}/src/main/config/checkstyle/checker.xml</configLocation> + <suppressionsLocation>${top.dir}/src/main/config/checkstyle/suppressions.xml</suppressionsLocation> + <consoleOutput>true</consoleOutput> + <headerLocation>${top.dir}/src/main/config/checkstyle/header.txt</headerLocation> + <failOnViolation><!--true-->false</failOnViolation> + <includeTestSourceDirectory><!--true-->false</includeTestSourceDirectory> + </configuration> + <goals> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-source-plugin</artifactId> + <version>2.2.1</version> + <executions> + <execution> + <id>attach-sources</id> + <phase>prepare-package</phase> + <goals> + <goal>jar-no-fork</goal> + </goals> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-javadoc-plugin</artifactId> + <version>2.9</version> + <configuration> + <quiet>true</quiet> + <links> + <link>http://hbase.apache.org/apidocs/</link> + </links> + </configuration> + <executions> + <execution> + <id>attach-javadocs</id> + <goals> + <!-- TODO turn back on javadocs - disabled now for testing --> + <!-- <goal>jar</goal> --> + </goals> + <configuration> + <additionalparam>${javadoc.opts}</additionalparam> + </configuration> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>${maven-surefire-plugin.version}</version> + <configuration> + <forkCount>${numForkedUT}</forkCount> + <reuseForks>true</reuseForks> + <argLine>-enableassertions -Xmx2250m -XX:MaxPermSize=128m + -Djava.security.egd=file:/dev/./urandom "-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}" -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/</argLine> + <redirectTestOutputToFile>${test.output.tofile}</redirectTestOutputToFile> + <shutdown>kill</shutdown> + </configuration> + </plugin> + <!-- All projects create a test jar --> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-jar-plugin</artifactId> + <version>2.4</version> + <executions> + <execution> + <phase>prepare-package + </phase> + <goals> + <goal>test-jar</goal> Review comment: nit: this is creating a test-jar for the parent also ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
