karanmehta93 commented on a change in pull request #433: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/433#discussion_r252070840
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
##########
@@ -464,6 +464,8 @@ public SQLException newException(SQLExceptionInfo info) {
INSUFFICIENT_MEMORY(999, "50M01", "Unable to allocate enough memory."),
HASH_JOIN_CACHE_NOT_FOUND(900, "HJ01", "Hash Join cache not found"),
+ STATS_COLLECTION_DISABLED_ON_SERVER(1401, "STS01", "Stats collection
attempted but is disabled on server"),
Review comment:
> In general the error codes appear to be grouped by number/purpose. Do we
have system level error code or stats codes?
Yes thats correct, there are some conventions. I am not sure if these are
followed here. Phoenix has a bunch of its own exception types not really
relevant to SQL.
> Do we want to reserve a prefix range for this 14XX?
I am not sure if we can do that and if yes, whats the way to do that.
> Consider moving to a different location for sorting reasons
Will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
